Skip to content

Conversation

@lugr-odoo
Copy link
Contributor

@lugr-odoo lugr-odoo commented Nov 7, 2025

The names of the accrual entry operations were updated. Plus new screenshots. (Plus a little dead code removal. 🤫)

Task ID: 5107300

@robodoo
Copy link
Collaborator

robodoo commented Nov 7, 2025

Pull request status dashboard

@lugr-odoo lugr-odoo force-pushed the 19.0-valuation_cheatsheet_accrual-lugr branch 2 times, most recently from dffc153 to afa30f5 Compare November 12, 2025 09:43
The names of the accrual entry operations were updated. New screenshots
were added.

Task ID: 5107300
This was a leftover from the original `entries.js` file.

Task ID: 5107300
@lugr-odoo lugr-odoo force-pushed the 19.0-valuation_cheatsheet_accrual-lugr branch from afa30f5 to 40522a4 Compare November 12, 2025 10:42
@lugr-odoo lugr-odoo marked this pull request as ready for review November 12, 2025 10:42
@C3POdoo C3POdoo requested review from a team November 12, 2025 10:45
@Feyensv Feyensv removed the request for review from a team November 13, 2025 13:02
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, @lugr-odoo !

Typically, we only push PRs with a single commit. This one has two, so I'm not sure whether it'll work (hope robodoo bot doesn't yell at us!)

I'll try merging first, and if it fails, could you squash the 2 commits into 1, and consider my very minor formatting change? (Let's only make the formatting change if you do need to commit).

@robodoo r+

Comment on lines +408 to +410
Receive`, :guilabel:`Invoices To Be Issued`, :guilabel:`Billed Not Received` and :guilabel:`Invoiced
Not Delivered`). Select the desired lines and click :guilabel:`Create Accrual
Entries`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Receive`, :guilabel:`Invoices To Be Issued`, :guilabel:`Billed Not Received` and :guilabel:`Invoiced
Not Delivered`). Select the desired lines and click :guilabel:`Create Accrual
Entries`.
Receive`, :guilabel:`Invoices To Be Issued`, :guilabel:`Billed Not Received` or :guilabel:`Invoiced
Not Delivered`). Select the desired lines and click :guilabel:`Create Accrual Entries`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's a bit too late now but I'll remember to incorporate this the next time around.

@robodoo
Copy link
Collaborator

robodoo commented Nov 13, 2025

@lugr-odoo @Felicious because this PR has multiple commits, I need to know how to merge it:

  • merge to merge directly, using the PR as merge commit message
  • rebase-merge to rebase and merge, using the PR as merge commit message
  • rebase-ff to rebase and fast-forward

@Felicious
Copy link
Contributor

@robodoo rebase-merge

@robodoo
Copy link
Collaborator

robodoo commented Nov 13, 2025

Merge method set to rebase and merge, using the PR as merge commit message.

robodoo pushed a commit that referenced this pull request Nov 14, 2025
The names of the accrual entry operations were updated. New screenshots
were added.

Task ID: 5107300

Part-of: #15179
Signed-off-by: Felicia Kuan (feku) <feku@odoo.com>
robodoo pushed a commit that referenced this pull request Nov 14, 2025
This was a leftover from the original `entries.js` file.

Task ID: 5107300

Part-of: #15179
Signed-off-by: Felicia Kuan (feku) <feku@odoo.com>
robodoo added a commit that referenced this pull request Nov 14, 2025
The names of the accrual entry operations were updated. Plus new screenshots. (Plus a little dead code removal. 🤫)

Task ID: [5107300](https://www.odoo.com/odoo/my-tasks/5107300)

closes #15179

Signed-off-by: Felicia Kuan (feku) <feku@odoo.com>
robodoo pushed a commit that referenced this pull request Nov 14, 2025
The names of the accrual entry operations were updated. New screenshots
were added.

Task ID: 5107300

Part-of: #15179
Signed-off-by: Felicia Kuan (feku) <feku@odoo.com>
robodoo pushed a commit that referenced this pull request Nov 14, 2025
This was a leftover from the original `entries.js` file.

Task ID: 5107300

Part-of: #15179
Signed-off-by: Felicia Kuan (feku) <feku@odoo.com>
@robodoo robodoo closed this in 3d46c50 Nov 14, 2025
robodoo added a commit that referenced this pull request Nov 14, 2025
The names of the accrual entry operations were updated. Plus new screenshots. (Plus a little dead code removal. 🤫)

Task ID: [5107300](https://www.odoo.com/odoo/my-tasks/5107300)

closes #15300

Forward-port-of: #15179
Signed-off-by: Felicia Kuan (feku) <feku@odoo.com>
Signed-off-by: Lulu Grimalkin (lugr) <lugr@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants